BUG: Silently pass NumericLocale test when locale unavailable#5936
Draft
hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Draft
BUG: Silently pass NumericLocale test when locale unavailable#5936hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
hjmjohnson wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Bug
dzenanz
approved these changes
Mar 13, 2026
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
I would like to update this test to try multiple European locales. But that is orthogonal to these changes.
Member
It is surprising how many system do not have this locale installed. I am not sure how these locale installation works on all these systems, but making this test silently pass with out testing any locale is going to give a false since of coverage. Is there another locale that is more widely available that could be used for testing? |
hjmjohnson
force-pushed
the
silence-test-not-run
branch
from
0a96337 to
f9575ec
Compare
Replace GTEST_SKIP() with a silent pass when de_DE.UTF-8 is not available. GTEST_SKIP reports the test as "not run" on CDash, generating warnings on the majority of CI configurations that lack this locale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
hjmjohnson
force-pushed
the
silence-test-not-run
branch
from
f9575ec to
46bb867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GTEST_SKIP()with a silent pass inNumericLocale.WorksWithDifferentInitialLocalewhende_DE.UTF-8is not availableGTEST_SKIPreports the test as "not run" on CDash, generating warnings on the majority of CI configurations that lack this localeTest plan
de_DE.UTF-8is available🤖 Generated with Claude Code