Skip to content

ENH: Use BUILD_INTERFACE generator expression for Python includes #5757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from
Closed

ENH: Use BUILD_INTERFACE generator expression for Python includes #5757

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fb9c29
Initial plan
Copilot Feb 3, 2026
a030818
ENH: Fix INTERFACE_INCLUDE_DIRECTORIES error for source-prefixed paths
Copilot Feb 3, 2026
ff78d32
ENH: Fix INTERFACE_INCLUDE_DIRECTORIES in ITKBridgeNumPy module
Copilot Feb 3, 2026
daebeaa
ENH: Use BUILD_INTERFACE generator expression for Python includes
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Modules/Bridge/NumPy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
cmake_minimum_required(VERSION 3.16.3)
project(ITKBridgeNumPy)

set(ITKBridgeNumPy_SYSTEM_INCLUDE_DIRS "${Python3_INCLUDE_DIRS}")
# Don't set SYSTEM_INCLUDE_DIRS for Python - handle includes separately
# to avoid CMake errors about source-prefixed paths in INTERFACE properties
set(ITKBridgeNumPy_SYSTEM_INCLUDE_DIRS "")

if(NOT ITK_SOURCE_DIR)
find_package(ITK REQUIRED)
Expand All @@ -10,3 +12,13 @@ if(NOT ITK_SOURCE_DIR)
else()
itk_module_impl()
endif()

# Add Python includes using BUILD_INTERFACE generator expression
# This ensures they're only used during build, not in exports
if(Python3_INCLUDE_DIRS AND TARGET ITKBridgeNumPyModule)
target_include_directories(ITKBridgeNumPyModule
SYSTEM
INTERFACE
$<BUILD_INTERFACE:${Python3_INCLUDE_DIRS}>
)
endif()