[ENH] ✨ LIST_GROUP of GenericLdapMapper should take ASI_GROUPS #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CChemin
reviewed
Aug 8, 2022
sugoi-api-ldap-utils/src/main/java/fr/insee/sugoi/ldap/utils/mapper/GenericLdapMapper.java
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Aug 8, 2022
sugoi-api-ldap-utils/src/main/java/fr/insee/sugoi/ldap/utils/mapper/GenericLdapMapper.java
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Aug 8, 2022
sugoi-api-ldap-utils/src/main/java/fr/insee/sugoi/ldap/utils/mapper/GenericLdapMapper.java
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Aug 8, 2022
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
2 times, most recently
from
a2e07e5 to
46a7f34
Compare
Contributor
Author
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
from
46a7f34 to
b5256cc
Compare
CChemin
reviewed
Aug 9, 2022
sugoi-api-ldap-utils/src/main/java/fr/insee/sugoi/ldap/utils/mapper/GenericLdapMapper.java
Outdated
Show resolved
Hide resolved
CChemin
reviewed
Aug 9, 2022
docs/configuration.md
Outdated
Contributor
There was a problem hiding this comment.
I mistook this variable with the variable fr.insee.sugoi.ldap.default.group_manager_source_pattern . Can you move the description to this variable and change the default ref in realm-configuration.md ?
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
2 times, most recently
from
5b16277 to
19ca1df
Compare
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
3 times, most recently
from
8de60d2 to
6db392d
Compare
Contributor
Author
|
Everything looks good with rebase, I added an optimization commit where some unnecessary lines were deleted. 👍 |
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
from
806abc4 to
1844614
Compare
clement-dufaure
force-pushed
the
add-asi-group-ldapconfig
branch
from
1844614 to
2572966
Compare
Comment on lines
1
to
534
Contributor
There was a problem hiding this comment.
Please remove this file
Contributor
There was a problem hiding this comment.
no, test checks if the user have admin group
Contributor
There was a problem hiding this comment.
test checks if user has at least a group of monappli2 app
Contributor
There was a problem hiding this comment.
check test message
mehdimaaref7
force-pushed
the
add-asi-group-ldapconfig
branch
2 times, most recently
from
be71cd2 to
f609fa8
Compare
clement-dufaure
approved these changes
Aug 29, 2022
Signed-off-by: Mehdi Maaref <mehdimaaref@live.fr>
Signed-off-by: Mehdi Maaref <mehdimaaref@live.fr>
clement-dufaure
force-pushed
the
add-asi-group-ldapconfig
branch
from
f609fa8 to
cd8c825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mehdi Maaref mehdimaaref@live.fr