[BUG] 💥 Fix getting external template on webhook call by loading from external source instead of directly from userstorage #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CChemin
force-pushed
the
fix-webhook
branch
2 times, most recently
from
831a401 to
dfc0caa
Compare
docs/realm-configuration.md
Outdated
Contributor
There was a problem hiding this comment.
not clear that the value expected is an URI to a template
(warn for a future issue : it seems that if uri is not well formed, just an exeption is thrown and default template is not used)
CChemin
force-pushed
the
fix-webhook
branch
3 times, most recently
from
53e87f4 to
4b4dfc3
Compare
… external source instead of directly from userstorage Signed-off-by: CChemin <cecile.chemin@insee.fr>
CChemin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.