Chore : Clean hook usage in UseLunatic #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grafikart
force-pushed
the
chore/clean-hooks-orchestrator
branch
2 times, most recently
from
02b6f64 to
e47083a
Compare
Grafikart
force-pushed
the
chore/clean-hooks-orchestrator
branch
from
e47083a to
ab18589
Compare
ddecrulle
reviewed
Sep 20, 2023
| @@ -1,4 +1,4 @@ | |||
| import { useEffect, useState, PropsWithChildren, useCallback } from 'react'; | |||
Contributor
There was a problem hiding this comment.
{ type PropsWithChildren, ...}`
| return personalization.reduce((acc, { name, value }) => { | ||
| return { ...acc, [name]: value }; | ||
| }, {}); | ||
| ): Record<string, string | number | boolean> { |
Contributor
There was a problem hiding this comment.
Why return type is not infered ?
| return Object.fromEntries(personalization.map((p) => [p.name, p.value])); | ||
| } | ||
|
|
||
| export function UseLunatic(props: PropsWithChildren<OrchestratorProps>) { |
Contributor
There was a problem hiding this comment.
Hooks must be uncapitalized in React ?
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hooks had bad pratices (setter in useEffect) that triggers unecessary renders.