feat(legacy): handle gender source variable for pairwise global variables #1121
Conversation
QRuhier
left a comment
QRuhier
left a comment
There was a problem hiding this comment.
The transformation stateToRemote is missing here (you still only persist Scope, not pairingSourceVariable object).
If i'm right, it's directly here : https://github.com/InseeFr/Pogues/blob/next/src/model/transformations/component.jsx#L730
Else it's nice !
src/constants/dictionary/pairing.ts
Outdated
| fr: 'Variable source du nom', | ||
| en: 'Name source variable', |
There was a problem hiding this comment.
It's more first name (as the business analysts confirmed)
There was a problem hiding this comment.
I'd rather keep the label as short as possible. Let's wait and see if business analysts deem necessary to change it or if it seems obvious to them for now.
There was a problem hiding this comment.
Yes we prefer "Variable source du Prénom", cause it's the main (and maybe only but can't be sure) use
chloe-renaud
changed the title
chloe-renaud
force-pushed
the
feat/pairwise-magic-variables
branch
from
641f03b to
ea4ec31
Compare
| ], | ||
| scope, | ||
| sourceVariableReferences, | ||
| scope, // deprecated |
There was a problem hiding this comment.
Great ! 🚀
We have to keep it because of generation of pogues-model -> DDI in EnoXML
ToDo: handle new modeling for this transformation (pogues->DDI) in https://github.com/InseeFr/Eno-Xml
chloe-renaud
force-pushed
the
feat/pairwise-magic-variables
branch
from
7da7732 to
d3b22dc
Compare
chloe-renaud
force-pushed
the
feat/pairwise-magic-variables
branch
from
d3b22dc to
9d4bf09
Compare
|
No description provided.