feat: add source variable references to handle pairwise global variables #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentC35
requested changes
Jan 14, 2026
Contributor
laurentC35
left a comment
laurentC35
left a comment
There was a problem hiding this comment.
A minor remark, but it's good for me.
Can you add a test to verify serialization for this SourceVariableReferences ?
| <xs:sequence> | ||
| <xs:element name="name" type="xs:token"/> | ||
| <xs:element name="gender" type="xs:token" minOccurs="0"/> | ||
| <xs:element name="age" type="xs:token" minOccurs="0"/> |
Contributor
There was a problem hiding this comment.
why age ?
I think is not usefull right now.
Are your preparing the future feature ?
Contributor
Author
There was a problem hiding this comment.
It is used by the recap component (which is merged in Pogues but hidden by a feature flag)...
chloe-renaud
changed the title
nsenave
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.