Skip to content

refactor!: remove deprecated properties and methods #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nsenave wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

refactor!: remove deprecated properties and methods #319

nsenave wants to merge 4 commits into from

Conversation

@nsenave
Copy link
Contributor

@nsenave nsenave commented Nov 13, 2025 •
edited
Loading

Some deprecated properties and methods have accumulated, let's clean this up.

  • remove deprecated properties
    • no longer used by Lunatic
    • old modeling (tpye change at some point)
  • for props that changed type, added proper getter methods (overriding the previous with old type)
  • remove deprecated String filePath methods

@nsenave nsenave requested a review from laurentC35 November 13, 2025 17:30
@nsenave nsenave requested a review from RemiVerriez November 13, 2025 17:36
@nsenave nsenave self-assigned this Nov 13, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RemiVerriez RemiVerriez RemiVerriez approved these changes

@laurentC35 laurentC35 Awaiting requested review from laurentC35

Assignees

@nsenave nsenave

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsenave @RemiVerriez