New Functionality For Block Respawning #222
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For respawning config and helper methods in respawn logic
Added functionality to tick() for block respawning if enabled
Owner
|
Two things.
|
Insane96
added
enhancement
Author
|
Sorry for the wait, is it better now? |
Owner
|
Def better. gonna review now |
Owner
|
Has this been tested with the feature disabled? |
Insane96
reviewed
Nov 9, 2025
| this.setFlags(EnumSet.of(Flag.LOOK, Flag.MOVE)); | ||
| } | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
Why all those empty lines between methods?
| import java.util.List; | ||
|
|
||
| public class MineTowardsTargetGoal extends Goal { | ||
| import static insane96mcp.enhancedai.modules.mobs.miner.MinerMobs.blacklistTileEntities; |
| if (this.miner.hasEffect(MobEffects.DIG_SLOWDOWN)) { | ||
| //noinspection ConstantConditions | ||
| float miningFatigueAmplifier = switch (this.miner.getEffect(MobEffects.DIG_SLOWDOWN).getAmplifier()) { | ||
| float f = switch (this.miner.getEffect(MobEffects.DIG_SLOWDOWN).getAmplifier()) { |
| SCALE_RESPAWN_BY_HARDNESS = EAIData.ofBool(this.createDataKey("scale_respawn_by_hardness")); | ||
| BASE_RESPAWN_TIME = EAIData.ofInt(this.createDataKey("base_respawn_time")); | ||
| HARDNESS_RESPAWN_MULTIPLIER = EAIData.ofDouble(this.createDataKey("hardness_respawn_multiplier")); | ||
| net.minecraftforge.common.MinecraftForge.EVENT_BUS.register(MineTowardsTargetGoal.class); |
| return data; | ||
| } | ||
|
|
||
|
|
Owner
There was a problem hiding this comment.
Just leave one empty line between methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added:
option for blocks to respawn at a configurable time
option for the respawn time to scale with hardness
respawn saves and respawn tile entities (saves nbt only if its a tile entity)
respawn drops/pushes out any blocks that obstruct the space of a respawning block
spawning is persistent across world load