feat: add CIP-20 transaction metadata to all write tools#28
Merged
Conversation
Attach CIP-20 (label 674) human-readable metadata to every unsigned
transaction built through buildUnsignedTx. Each transaction now includes
"Indigo Protocol: {type}" and a description line, making protocol
operations identifiable on-chain via block explorers.
Centralize .complete() in tx-builder.ts so metadata is attached after
the TxBuilder is returned from each tool's buildFn callback but before
finalization. Remove .complete() calls from all 27 write tool callbacks
across 10 files.
adacapo21
force-pushed
the
feat/3RD-389-add-cip20-transaction-metadata
branch
from
7eda6b1 to
576c734
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.complete()intx-builder.tsso metadata is attached betweenTxBuildercreation and finalization.complete()calls from all 27 write tool callbacks across 10 files — they now returnTxBuilderdirectlyTest plan
npm run typecheck— passesnpm run build— compiles without errorsnpm run lint(src/) — passesnpm run test— 102 tests pass