Skip to content

Improve Digital Bid Adapter: Added compression support for outgoing requests #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lyubomirshishkov merged 3 commits into from
Jun 9, 2025
Merged

Improve Digital Bid Adapter: Added compression support for outgoing requests #25

lyubomirshishkov merged 3 commits into from
Jun 9, 2025

Conversation

@lyubomirshishkov
Copy link
Collaborator

@lyubomirshishkov lyubomirshishkov commented Jun 3, 2025

Type of change

  • Feature

Description of change

Adding compression support for the Improve Digital Bid Adapter's outgoing requests.

Other information

Related documentation in Prebid.org

@lyubomirshishkov
## FMSC-1967 - Enable request compression in Improve Digital Prebid J…
5d1b19d 
…S adapter

* **Type:** Feature
* **Scope:** improvedigitalBidAdapter.js, improvedigitalBidAdapter_spec.js
* **Subject:** Enables request compression in Improve Digital's Prebid JS Bid Adapter
* **Breaks:** N/A
@lyubomirshishkov lyubomirshishkov self-assigned this Jun 3, 2025
@github-actions

This comment was marked as resolved.

Sign in to view
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Tread carefully! This PR adds 12 linter errors (possibly disabled through directives):

  • creative/constants.js (+2 errors)
  • libraries/boundingClientRect/boundingClientRect.js (+1 error)
  • modules/mobkoiAnalyticsAdapter.js (+1 error)
  • modules/pubmaticBidAdapter.js (+7 errors)
  • modules/pubmaticRtdProvider.js (+1 error)

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Whoa there, partner! 🌵🤠 We wrangled some duplicated code in your PR:

Reducing code duplication by importing common functions from a library not only makes our code cleaner but also easier to maintain. Please move the common code from both files into a library and import it in each. We hate that we have to mention this, however, commits designed to hide from this utility by renaming variables or reordering an object are poor conduct. We will not look upon them kindly! Keep up the great work! 🚀

@github-actions
Copy link

github-actions bot commented Jun 3, 2025

Tread carefully! This PR adds 12 linter errors (possibly disabled through directives):

  • creative/constants.js (+2 errors)
  • libraries/boundingClientRect/boundingClientRect.js (+1 error)
  • modules/mobkoiAnalyticsAdapter.js (+1 error)
  • modules/pubmaticBidAdapter.js (+7 errors)
  • modules/pubmaticRtdProvider.js (+1 error)

@lyubomirshishkov lyubomirshishkov merged commit f7a9af6 into master Jun 9, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbartek25 jbartek25 jbartek25 approved these changes

@i-atanasov-az i-atanasov-az i-atanasov-az approved these changes

Assignees

@lyubomirshishkov lyubomirshishkov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyubomirshishkov @jbartek25 @i-atanasov-az