Clean up implementation of enable/disable of tx over regions#481
Open
MedadRufus wants to merge 36 commits intoicspace-devfrom
Open
Clean up implementation of enable/disable of tx over regions#481MedadRufus wants to merge 36 commits intoicspace-devfrom
MedadRufus wants to merge 36 commits intoicspace-devfrom
Conversation
Member
Author
|
TODO:
|
MedadRufus
commented
Jan 17, 2023
src/peripherals/geofence.c
Outdated
| @@ -1038,10 +999,7 @@ Polygon_t get_polygon(float latitude, float longitude) | |||
| tx_permission_t get_permissions(Polygon_t currentpoly) | |||
| { | |||
| // then lookup value. Danger, there is no bounds validation for current poly. Can cause corruption. | |||
Member
Author
There was a problem hiding this comment.
do add the bounds check
MedadRufus
commented
Jan 17, 2023
MedadRufus
commented
Jan 17, 2023
MedadRufus
commented
Jan 18, 2023
| void read_geofence_settings_in_eeprom(bool *values) | ||
| void read_geofence_settings_in_eeprom(tx_permission_t *values) | ||
| { | ||
| // todo: check non-null |
MedadRufus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use much easier to maintain C99 style array indexes to keep track of polygons and where they can transmit from.