Skip to content

Conversation

@ivanimanishi
Copy link
Member

As suggested by John, I've changed the SConstruct so that the "private" headers do get installed.

The specific use-case for accessing them is the effort to move the dcc-specific modules out of the public cortex repository. And since some of those private headers are needed by them, the simplest solution is to have them accessible from the installed locations.

Even though the requirement to have those repositories outside of cortex is only for 10.6, targeting this PR to 10.5 makes our transition easier.

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Cortex project's prevailing coding style and conventions.

@ivanimanishi ivanimanishi requested a review from johnhaddon July 30, 2025 17:01
@johnhaddon
Copy link
Member

Even though the requirement to have those repositories outside of cortex is only for 10.6, targeting this PR to 10.5 makes our transition easier.

The PR is targeted to main - did you mean for it to be RB-10.5 or is the comment inaccurate? Otherwise, LGTM.

@ivanimanishi ivanimanishi changed the base branch from main to RB-10.5 August 14, 2025 15:57
@ivanimanishi
Copy link
Member Author

Even though the requirement to have those repositories outside of cortex is only for 10.6, targeting this PR to 10.5 makes our transition easier.

The PR is targeted to main - did you mean for it to be RB-10.5 or is the comment inaccurate? Otherwise, LGTM.

The comment was accurate. I just messed up the PR creation somehow. It's updated to target RB-10.5 now.

@johnhaddon johnhaddon merged commit 39e1c91 into ImageEngine:RB-10.5 Aug 14, 2025
5 checks passed
@johnhaddon
Copy link
Member

It's updated to target RB-10.5 now.

Thanks - merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants