fix: improve CDP detection by checking actual port connection#1
Open
l1veIn wants to merge 1 commit intoImL1s:mainfrom
Open
fix: improve CDP detection by checking actual port connection#1l1veIn wants to merge 1 commit intoImL1s:mainfrom
l1veIn wants to merge 1 commit intoImL1s:mainfrom
Conversation
- Changed isCDPEnabled() to verify by connecting to CDP port instead of checking process.argv - Extension now tries to connect to CDP on startup and shows warning only if connection fails - Include ws module in vsix package (required runtime dependency) - Updated .vscodeignore to exclude only devDependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The extension was checking
process.argvto determine if CDP was enabled, but VSCode extension host process doesn't receive the Electron main process arguments. This caused the extension to always show 'CDP not enabled' warning even when CDP was actually working.Solution
process.argvverifyCDPConnection()method - Async method that verifies CDP by HTTP request to/json/versionwsmodule which is a required runtime dependency (was being excluded by.vscodeignore)Changes
lib/relauncher.js: UpdatedisCDPEnabled()and addedverifyCDPConnection()extension.js: Changed startup flow to try connecting first, only show warning if connection fails.vscodeignore: Only exclude devDependencies, keepnode_modules/wspackage.json: Loweredengines.vscodeto^1.100.0for broader compatibilityTesting
Tested on macOS with Antigravity IDE 1.104.0:
/Applications/Antigravity.app/Contents/MacOS/Electron --remote-debugging-port=9000