Open
Conversation
|
Until this is merged into the official repo, I've merged it into my fork @ https://github.com/bw2/SpliceAI |
|
@jeremymcrae do you have merge permissions for this repository and could publish a new release including this PR? |
|
This PR fails for the following variant: |
|
I think this commit fixes the problem, would you mind checking @kdahlo @bw2 ? Basically, we re-use the first if-case by inserting only enough zeros to match the size of the reference sequence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows SpliceAI to provide delta scores for MNPs (Multiple Nucleotide Polymorphisms). Previous SpliceAI behavior was to filter MNPs without performing calculations. This change allows for calculation of delta scores on MNPs without changing the way that delta scores are calculated for other variants. Under this change, the delta score of the ALT allele is calculated by taking the maximum score across the ALT allele, and comparing the maximum score against the first nucleotide of the REF allele. This practice is similar to the existing practice of SpliceAI when the ALT allele contains an insertion.