Skip to content

Fixed typos with Booleans#2

Open
JdotCarver wants to merge 1 commit intoIk1497:mainfrom
JdotCarver:patch-1
Open

Fixed typos with Booleans#2
JdotCarver wants to merge 1 commit intoIk1497:mainfrom
JdotCarver:patch-1

Conversation

@JdotCarver
Copy link

Booleans are not capitalized.

Unless it's a design philosophy?
Which I do not agree with because it introduces unnecessary correction operations on each snippet autocomplete. Which needless to say is counterintuitive to the idea of autocomplete saving time.

Booleans are not capitalized.
Copy link

@JeffHund JeffHund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booleans are not capitalized in C#. You will receive a CS0103 compiler error if either true or false are capitalized.

https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/bool

@JdotCarver
Copy link
Author

Yeah sorry, cryptic PR. 😄
The original code has booleans capitalized.
This PR that I am submitting is UNcapitalizing them to fix, as you say, the C# error that you will get.

If you check the code you'll see.

Copy link

@JeffHund JeffHund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! That's my bad -- this is a good change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants