Skip to content

Conversation

@taxus13
Copy link

@taxus13 taxus13 commented Jun 9, 2025

  • Add tool: BLE to Websockets bridge
  • Disable logging of BLE events
  • Disable flashing of LED if none is available
  • Use defines to disable BLE or Websockets entirely (maybe move define to platformio.ini or Constants.h)
  • Change default update interval and configure the default value in Constants.h
  • Select pin configuration for thermocouples based on board configured in platformio.ini

I would also like to change the version from double to string, so semantic versioning can be used. What do you think?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is comment is not necessary. Since debugln(x) is macro Serial.println(x), it will not shown while not monitor it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I was forgot to move this value into Constant.h. But the value was presented as second in int. Also the value was passed into ICRM App. change data type will need changes to the app too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be best to store it as int in milliseconds, because the usage is always in miliseconds. Currently it is converted every time the BLE stack sends new data. I was also thinking if it would be good to have to separate values for Websockets and BLE.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll move USE_WEBSOCKET and USE_BLE to Constants.h like this :

// Check is BLE connection supported
// Change to `false` if you do not wish to use
#define USE_BLE defined(ESP32) and true

// Change to `false` if you do not wish to use
#define USE_WEBSOCKET true

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, we have #define, const bool, and static constexpr in Constants.h. The best C++ way and to have it type safe would be only using static constexpr, it is type safe and is evaluated during compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants