Open
Conversation
Contributor
Author
|
@andywingo Are you happy with convert_ssa and convert_ast taking an extra boolean parameter for whether to apply optimizations? |
Contributor
|
I can see us wanting more than one option, for example to turn specific optimizations on or off. Actually the printing could be done by e.g. ssa.lua itself if the debug_ssa option is set. Dunno yo. I'm kinda negative on adding boolean options. Boolean options, especially optional booleans, are an antipattern :) If you want to go ahead please use option dicts and utils.parse_opts but let's treat this as low-priority for now |
Marked pflua-expand as obsolete; replaced by shell script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to dump the AST, ANF, and SSA IRs to pflua-compile, with and without optimization.
Obsolete pflua-expand.
Update other tools/internals to reflect convert_anf and convert_ssa requiring an optimize argument.