Skip to content

Implement Implicit "OR"#17

Open
dpino wants to merge 1 commit intomasterfrom
issue-17-implement-implicit-or
Open

Implement Implicit "OR"#17
dpino wants to merge 1 commit intomasterfrom
issue-17-implement-implicit-or

Conversation

@dpino
Copy link
Member

@dpino dpino commented Aug 14, 2014

The pflang documentation says:

If an identifier is given without a keyword, the most recent keyword is assumed. For example,
not host vs and ace
is short for
not host vs and host ace
which should not be confused with
not ( host vs or ace )

Pflua currently does not implement implicit OR, and probably should do so. Steve McCanne seemed to think it was pretty important in http://sharkfest.wireshark.org/sharkfest.11/presentations/McCanne-Sharkfest'11_Keynote_Address.pdf, though I find it to be a source of ambiguity in the language.

dpino added a commit that referenced this pull request Aug 14, 2014
If an identifier is given without a keyword, the most recent keyword is assumed. For example,

   not host vs and ace

is short for

   not host vs and host ace

Which should not be confused with

   not ( host vs or ace )

This patch fixes issue #17.
@dpino dpino force-pushed the issue-17-implement-implicit-or branch from 2f685f2 to 51f6da1 Compare September 3, 2014 18:16
dpino added a commit that referenced this pull request Sep 3, 2014
If an identifier is given without a keyword, the most recent keyword is assumed. For example,

   not host vs and ace

is short for

   not host vs and host ace

Which should not be confused with

   not ( host vs or ace )

This patch fixes issue #17.
If an identifier is given without a keyword, the most recent keyword is assumed. For example,

   not host vs and ace

is short for

   not host vs and host ace

Which should not be confused with

   not ( host vs or ace )

This patch fixes issue #17.
@dpino dpino force-pushed the issue-17-implement-implicit-or branch from 51f6da1 to edd2622 Compare December 10, 2014 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants