Draft
Conversation
aperezdc
requested changes
Aug 31, 2023
Member
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
There's an issue in the patch, please see the comment about mixing C and C++ code below.
| static bool initialized = false; | ||
|
|
||
| if (!initialized) { | ||
| GUniqueOutPtr<GdkKeymapKey> keys; |
Member
There was a problem hiding this comment.
This won't work on a plain C source. It looks like you were picking from C++ code from elsewhere, so this will need adapting to compile as C99.
| } | ||
|
|
||
| static gboolean | ||
| is_pressed_key(guint keyval) |
Member
There was a problem hiding this comment.
Small nit: naming this is_key_pressed() would read more naturally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on WebPlatformForEmbedded/libwpe#128.
Implement handling of CAPS_LOCK and NUM_LOCK for several layers (GTK4, Wayland, X11).