Conversation
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
@EinarArnason Hi there, thanks for the the patch! I am definitely not against the feature, but I would rather not change the existing behaviour by default. Would you consider making the retry interval a configurable option?
core/cog-webkit-utils.c
Outdated
| "</style></head><body>\n" | ||
| "</style>\n" | ||
| "<script>\nfunction retry() { window.location.href = '%s' }\n" | ||
| "setTimeout(retry, 5000);\n</script></head><body>\n" |
There was a problem hiding this comment.
This make the “retry every five seconds” behaviour unconditional, and I can imagine there may be cases in which this is not desired. It would be better if we could have an option to configure (or disable) the retry interval.
There was a problem hiding this comment.
You're right, an option would be best. Should it be disabled by default?
There was a problem hiding this comment.
Yes, disabled by default would keep the current behaviour by default, to avoid breaking people's setups. Thanks for considering reworking the patch 😸
|
hello, can you commit this patch ? |
3 participants
Retries the failing URL on 5 second interval