Implement DOM fullscreen requests in fdo backend#329
Merged
aperezdc merged 2 commits intoIgalia:masterfrom Aug 9, 2021
Merged
Conversation
Contributor
MortimerGoro
commented
Jul 14, 2021
MortimerGoro
commented
- Enter fullscreen via DOM requests or keyboard key
- Exit fullscreen via keyboard key
Contributor
Author
|
Depends on WebPlatformForEmbedded/libwpe#86 |
MortimerGoro
force-pushed
the
mortimer/fullscreen
branch
from
f3d3339 to
75b9151
Compare
aperezdc
requested changes
Jul 27, 2021
Member
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
This is looking promising; the only remaining part being that it only works with the xdg_wm_base protocol, but the code is written to support also wl_shell, and zwp_fullscreen_shell_v1... Could you please take a look into adding support for them?
Thanks a ton for working on this 😃
aperezdc
requested changes
Aug 3, 2021
Member
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
Other than the style checker issues, I think this is good to go—as long as others agree on the API addition from WebPlatformForEmbedded/libwpe#86 😄
MortimerGoro
force-pushed
the
mortimer/fullscreen
branch
from
6e329a6 to
556f33a
Compare
MortimerGoro
force-pushed
the
mortimer/fullscreen
branch
from
556f33a to
cd641f8
Compare
Contributor
Author
Done! |
aperezdc
approved these changes
Aug 9, 2021
Member
aperezdc
left a comment
aperezdc
left a comment
There was a problem hiding this comment.
Thanks for doing one more last update to this PR, I think it's now ready 👌🏼
aperezdc
added a commit
that referenced
this pull request
Aug 9, 2021
- Move the version checks to the top of the source files, accounting for the WPE_CHECK_VERSION() macro not present in older versions of libwpe. - Designated initializers do not need to specify NULL/0/false, as it is the default. - Fix some indenting around the touched lines.
aperezdc
added a commit
that referenced
this pull request
Aug 9, 2021
- Move the version checks to the top of the source files, accounting for the WPE_CHECK_VERSION() macro not present in older versions of libwpe. - Designated initializers do not need to specify NULL/0/false, as it is the default. - Fix some indenting around the touched lines.
aperezdc
added a commit
that referenced
this pull request
Aug 12, 2021
- Move the version checks to the top of the source files, accounting for the WPE_CHECK_VERSION() macro not present in older versions of libwpe. - Designated initializers do not need to specify NULL/0/false, as it is the default. - Fix some indenting around the touched lines.
EinarArnason
pushed a commit
to EinarArnason/cog
that referenced
this pull request
May 16, 2022
- Move the version checks to the top of the source files, accounting for the WPE_CHECK_VERSION() macro not present in older versions of libwpe. - Designated initializers do not need to specify NULL/0/false, as it is the default. - Fix some indenting around the touched lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.