Skip to content

Conversation

@dmitryd
Copy link

@dmitryd dmitryd commented Mar 21, 2024

Missing:

  • Tests
  • Some TODOs

Please, feel free to improve (especially tests!).

@kitzberger
Copy link

kitzberger commented Feb 17, 2025

@dmitryd, thanks for your efforts. Images are being fetched from the remote server again, yeah!

But I've got an exception in the BE when trying to edit a storage record:

image

As I understand the #Exclude attribute in https://github.com/TYPO3/typo3/blob/v13.4.5/typo3/sysext/core/Classes/Localization/LanguageService.php#L45 this class cannot be injected via DI in TYPO3 13, that's why we need to create an instance manually. Like the core is doing.

@kitzberger
Copy link

Additionally from the deprecation log:

  • Deprecated: IchHabRecht\Filefill\Resource\Handler\DomainResource::__construct(): Implicitly marking parameter $requestFactory as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/Handler/DomainResource.php on line 38
  • Deprecated: IchHabRecht\Filefill\Resource\Handler\DomainResource::hasFile(): Implicitly marking parameter $fileObject as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/Handler/DomainResource.php on line 52
  • Deprecated: IchHabRecht\Filefill\Resource\Handler\DomainResource::getFile(): Implicitly marking parameter $fileObject as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/Handler/DomainResource.php on line 69
  • Deprecated: IchHabRecht\Filefill\Resource\RemoteResourceInterface::hasFile(): Implicitly marking parameter $fileObject as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/RemoteResourceInterface.php on line 30
  • Deprecated: IchHabRecht\Filefill\Resource\RemoteResourceInterface::getFile(): Implicitly marking parameter $fileObject as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/RemoteResourceInterface.php on line 38
  • Deprecated: IchHabRecht\Filefill\Resource\RemoteResourceCollection::__construct(): Implicitly marking parameter $resourceFactory as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/RemoteResourceCollection.php on line 65
  • Deprecated: IchHabRecht\Filefill\Resource\RemoteResourceCollection::__construct(): Implicitly marking parameter $fileRepository as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Resource/RemoteResourceCollection.php on line 65
  • Deprecated: IchHabRecht\Filefill\Repository\FileRepository::__construct(): Implicitly marking parameter $connection as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Repository/FileRepository.php on line 36
  • Deprecated: IchHabRecht\Filefill\Repository\FileRepository::__construct(): Implicitly marking parameter $processedFileRepository as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Repository/FileRepository.php on line 36
  • Deprecated: IchHabRecht\Filefill\Repository\FileRepository::__construct(): Implicitly marking parameter $resourceFactory as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/ichhabrecht/filefill/Classes/Repository/FileRepository.php on line 36

@mbrodala
Copy link
Contributor

Guess this is obsolete by now, version 5.0.0 requires TYPO3v13 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants