Add support for specifying custom :meta options.#37
Open
retmanski wants to merge 1 commit intoIcaliaLabs:masterfrom
Open
Add support for specifying custom :meta options.#37retmanski wants to merge 1 commit intoIcaliaLabs:masterfrom
:meta options.#37retmanski wants to merge 1 commit intoIcaliaLabs:masterfrom
Conversation
Currently the pagination implementation completely overwrites the response `:meta` options - I have a use case that requires adding additional options to the meta section but the gem doesn't support that. This change allows something like the following to work as expected:
```
paginate my_collection, meta: { foo: 'bar' }
```
And will include the specified custom metadata in addition to the pagination metadata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
:metaoptions - I have a use case that requires adding additional options to the meta section but the gem doesn't support that. This change allows something like the following to work as expected:...and will include the specified custom metadata in addition to the pagination metadata.