Skip to content

Conversation

@OsamaHaikal
Copy link
Contributor

After seeing a big speed boost from switching to uv, I wanted to try Ruff, a Rust-based formatter and linter. It’s super fast and can replace Black, Flake8, and isort all in one.

In this PR:
Added Ruff for formatting and linting
Kept it compatible with the previous setup
Removed Black, Flake8, and isort since Ruff handles everything

Let me know what you think!

@IbraheemTuffaha
Copy link
Owner

I love it!
I just approved the GitHub Actions run..
Can you please update the GitHub Actions too to use ruff?

avoig conflict between hook and local
@OsamaHaikal
Copy link
Contributor Author

Updated the action and pushed a fixup commit ( can be auto squashed on merged)

@IbraheemTuffaha
Copy link
Owner

So wemake-python-styleguide is an extension to flake8.. so now we can just remove it from dependencies

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Copy link
Owner

@IbraheemTuffaha IbraheemTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few changes, if they look good to you, then we can merge

@OsamaHaikal
Copy link
Contributor Author

Yes looks great, sorry I did not check the whole code base and missed up some changes

@IbraheemTuffaha IbraheemTuffaha merged commit d86271d into IbraheemTuffaha:main Mar 6, 2025
5 checks passed
@IbraheemTuffaha
Copy link
Owner

Thanks a lot for your contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants