Remove header, footer for embedded application#15
Open
dianaboiangiu wants to merge 1 commit intomasterfrom
Open
Remove header, footer for embedded application#15dianaboiangiu wants to merge 1 commit intomasterfrom
dianaboiangiu wants to merge 1 commit intomasterfrom
Conversation
melish
reviewed
May 18, 2018
| @@ -0,0 +1,6 @@ | |||
| def set_iframe(request): | |||
| if 'HTTP_REFERER' in request.META: | |||
Member
There was a problem hiding this comment.
Probably a bad idea, referrer is not only sent for iframes, but also when clicking on a normal link to the other website
Member
There was a problem hiding this comment.
I suggest to implement an explicit request parameter, "&headless=true" instead
melish
requested changes
May 18, 2018
Member
melish
left a comment
melish
left a comment
There was a problem hiding this comment.
see comment about meta referrer and url parameter headless=true
melish
force-pushed
the
master
branch
2 times, most recently
from
d47482b to
b769110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.