[cpp] use smart pointers everywhere#26
Open
vmedv wants to merge 2 commits intoITMO-PTDC-Team:masterfrom
Open
Conversation
vmedv
force-pushed
the
cpp-make-key-value-hardcoded
branch
from
38bf018 to
d59e6ec
Compare
Mr-Ravil
reviewed
Mar 17, 2026
| std::shared_ptr<ArgsGenerator<K>> range_generator_; | ||
| ArgsGeneratorPtr get_generator_; | ||
| ArgsGeneratorPtr insert_generator_; | ||
| ArgsGeneratorPtr remove_generator_; |
Member
There was a problem hiding this comment.
один генератор может отвечать за несколько разных операций
Contributor
Author
There was a problem hiding this comment.
все перевел на шареды
Mr-Ravil
reviewed
Mar 17, 2026
| @@ -1,6 +0,0 @@ | |||
| all: | |||
| g++ -I. -I.. -I../../common -I../.. -I../../ -pthread -ldl -mrtm json_example.cpp -o json_example.out | |||
Member
There was a problem hiding this comment.
сделай здесь же cmake файл для компиляции примера
Contributor
Author
There was a problem hiding this comment.
пока не получится, так как оно зависит от DS, а внутри microbench мы про DS не знаем. это можно будет, когда я развяжу микробенч и все остальное
Mr-Ravil
reviewed
Mar 17, 2026
| Parameters* warmUp; | ||
| Parameters test{}; | ||
| Parameters prefill{}; | ||
| Parameters warmUp{}; |
Member
There was a problem hiding this comment.
давай сделаем optional, чтобы можно было скипать один из этапов
Contributor
Author
There was a problem hiding this comment.
сделал, проверил, example json соответствующе изменил
Mr-Ravil
reviewed
Mar 17, 2026
| @@ -0,0 +1,85 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
надо выпилить (оставив все примеры в json_example)
- remove extra file - use shared pointers everywhere to pessimise state sharing - introduce optionals to bench params
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR remove all templates in prior to truly hardcoded types since since global extern defines anyway did not work flawlessly
real support of different types will be introduced later
Closes #5, Replaces #18