Open
Conversation
Contributor
Author
|
Я решил добавить |
…erting data from index map to actual
Mr-Ravil
reviewed
Sep 17, 2025
Member
Mr-Ravil
left a comment
Mr-Ravil
left a comment
There was a problem hiding this comment.
Первый взгляд на решение. Подробрее гляну на выходных. А так же посмотрю по поводу garbage, и отпишусь по нему отдельно
Mr-Ravil
reviewed
Sep 24, 2025
Member
There was a problem hiding this comment.
было бы ещё неплохо добавить пример с DataMap
Member
There was a problem hiding this comment.
Было бы неплохо добавить информацию о DataMap в toString
Mr-Ravil
reviewed
Oct 1, 2025
vmedv
reviewed
Oct 8, 2025
Contributor
There was a problem hiding this comment.
кажется этого не должно быть в дифе, тк схема жсона не меняется, а меняются только значения
Comment on lines
+25
to
+33
| #ifdef USE_STRING | ||
| #include "string_data_map.h" | ||
| return new StringDataMap(1); | ||
| #endif | ||
| } else if constexpr (std::is_same_v<KEY_TYPE, long long>) { | ||
| #ifdef USE_LONG_LONG | ||
| #include "int_data_map.h" | ||
| return new IntDataMap(1); | ||
| #endif |
Contributor
There was a problem hiding this comment.
зачем инклюдить тут? не надо так делать, заинклюдь как обычно выше
Comment on lines
-8
to
+18
| typedef long long test_type; | ||
| #include "global_types.h" | ||
|
|
||
| #ifdef REDIS | ||
| #define VALUE_TYPE test_type | ||
| #define KEY_TO_VALUE(key) key | ||
| #define GET_FUNC executeContains | ||
| #else | ||
| #define VALUE_TYPE void * | ||
| #define KEY_TO_VALUE(key) &key /* note: hack to turn a key into a pointer */ | ||
| #define GET_FUNC executeGet | ||
| #endif | ||
|
|
||
| #define DS_ADAPTER_T ds_adapter<test_type, VALUE_TYPE, RECLAIM<>, ALLOC<>, POOL<> > | ||
| #define DS_ADAPTER_T ds_adapter<KEY_TYPE, VALUE_TYPE, RECLAIM<>, ALLOC<>, POOL<> > |
Contributor
There was a problem hiding this comment.
так может все это в целом перенести в global types? зачем размазывать по разным файлам
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.