Conversation
rerpha
reviewed
Feb 26, 2025
BlockServer/core/ioc_control.py
Outdated
| curr = self._proc.get_autorestart(ioc) | ||
| if curr != enable: | ||
| # If different to requested then change it | ||
| print_and_log(f"Auto-restart for IOC {ioc} is not {enable}") |
Contributor
There was a problem hiding this comment.
i think this sounds like an error. is
Suggested change
| print_and_log(f"Auto-restart for IOC {ioc} is not {enable}") | |
| print_and_log(f"Auto-restart for IOC {ioc} not set to {enable}, toggling") |
better?
Member
Author
There was a problem hiding this comment.
The function it calls contains print_and_log(f"Toggling auto-restart for IOC {ioc}") so i didn't feel toggling needed mentioning here too. Happy to change is not True to not set to True
rerpha
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Additional printing to help trace autorestart test failure
Code Review
Functional Tests
Final steps