Skip to content

Move start message to better place#409

Merged
rerpha merged 4 commits intomasterfrom
move_start_message
Feb 27, 2025
Merged

Move start message to better place#409
rerpha merged 4 commits intomasterfrom
move_start_message

Conversation

@FreddieAkeroyd
Copy link
Member

Description of work

Move start message so only printed if ioc actually starts


Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@FreddieAkeroyd FreddieAkeroyd moved this to Flash Review in Tasks Feb 26, 2025
@rerpha
Copy link
Contributor

rerpha commented Feb 27, 2025

change looks fine, not sure why CI is breaking - may need if TYPE_CHECKING to avoid circular import

@rerpha rerpha merged commit 25f6953 into master Feb 27, 2025
2 of 3 checks passed
@rerpha rerpha deleted the move_start_message branch February 27, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants