Skip to content

Type-hint seci as Literal[False] rather than bool. Update HIFI/ARGUS.#408

Merged
rerpha merged 1 commit intomasterfrom
add_hifi_to_inst_list
Jan 22, 2025
Merged

Type-hint seci as Literal[False] rather than bool. Update HIFI/ARGUS.#408
rerpha merged 1 commit intomasterfrom
add_hifi_to_inst_list

Conversation

@Tom-Willemsen
Copy link
Member

Description of work

Add HIFI/ARGUS as IBEX to the instrument list, remove support for seci being anything other than False.


Code Review

  • Is the code of an acceptable quality?
  • Has the author taken into account the multi-threaded nature of the code?
  • Have the changes been recorded appropriately in a PR for release notes?
  • Has the manual system tests spreadsheet been updated?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed.

Final steps

  • Reviewer has updated the submodule in the main EPICS repo? See Reviewing work for the subModules of EPICS in the Git workflow page for details.
  • Reviewer has merged the associated PR for the release notes

@Tom-Willemsen Tom-Willemsen changed the title Remove support for seci being anything other than False. Update HIFI/ARGUS. Type-hint seci as Literal[False] rather than bool. Update HIFI/ARGUS. Jan 21, 2025
@rerpha rerpha merged commit 45f53c3 into master Jan 22, 2025
2 checks passed
@rerpha rerpha deleted the add_hifi_to_inst_list branch January 22, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants