Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@
<org.glassfish.jaxb.xsom.version>2.3.3-b02</org.glassfish.jaxb.xsom.version>
<undertow.version>${undertow-legacy.version}</undertow.version>
<undertow-legacy.version>2.2.24.Final</undertow-legacy.version>
<undertow-jakarta.version>2.3.2.Final</undertow-jakarta.version>
<undertow-jakarta.version>2.3.21.Final</undertow-jakarta.version>
<wildfly-elytron.version>2.5.2.Final</wildfly-elytron.version>
<elytron.undertow-server.version>1.9.0.Final</elytron.undertow-server.version>
<woodstox.version>6.0.3</woodstox.version>
Expand Down Expand Up @@ -278,7 +278,7 @@
</developer>
</developers>

<contributors></contributors>
<contributors/>

<modules>
<module>boms</module>
Expand Down Expand Up @@ -1600,7 +1600,7 @@
<properties>
<ee.maven.groupId>org.jboss.eap</ee.maven.groupId>
<ee.maven.version>${eap8.version}</ee.maven.version>
<wildfly.version>${eap8.version}</wildfly.version>
<wildfly.version>39.0.0.Final</wildfly.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: In the eap8-adapters profile, wildfly.version is now hard-coded to 39.0.0.Final while ee.maven.groupId is org.jboss.eap and ee.maven.version is ${eap8.version} (e.g. 8.0.0.GA-redhat-00007), so dependencies like org.jboss.eap:wildfly-ee-galleon-pack:${wildfly.version} will point to a likely non-existent GAV and cause resolution/build failures when this profile is used; wildfly.version should remain aligned with the EAP version. [logic error]

Severity Level: Critical 🚨
- ❌ EAP8 adapter build fails resolving wildfly-ee-galleon-pack.
- ⚠️ EAP8 profile unusable for downstream adapter testing.
Suggested change
<wildfly.version>39.0.0.Final</wildfly.version>
<wildfly.version>${eap8.version}</wildfly.version>
Steps of Reproduction ✅
1. From the project root (`/workspace/keycloak`), run Maven with the EAP8 adapters profile
enabled, for example: `mvn -Peap8-adapters dependency:tree`.

2. Maven activates the `eap8-adapters` profile defined in `pom.xml:1593-1607`, setting
`ee.maven.groupId=org.jboss.eap`, `ee.maven.version=${eap8.version}`
(`8.0.0.GA-redhat-00007`), and `wildfly.version=39.0.0.Final`.

3. During dependency resolution, Maven processes the dependency management entry at
`pom.xml:746-748`:

   `<groupId>${ee.maven.groupId}</groupId>`,
   `<artifactId>wildfly-ee-galleon-pack</artifactId>`,
   `<version>${wildfly.version}</version>`, which evaluates to
   `org.jboss.eap:wildfly-ee-galleon-pack:39.0.0.Final`.

4. Maven attempts to resolve `org.jboss.eap:wildfly-ee-galleon-pack:39.0.0.Final` (and
related EAP artifacts using `${wildfly.version}`) and fails because this version does not
correspond to the configured EAP 8 GAVs, causing dependency resolution/build failure
whenever the `eap8-adapters` profile is used.
Prompt for AI Agent 🤖
This is a comment left during a code review.

**Path:** pom.xml
**Line:** 1603:1603
**Comment:**
	*Logic Error: In the `eap8-adapters` profile, `wildfly.version` is now hard-coded to `39.0.0.Final` while `ee.maven.groupId` is `org.jboss.eap` and `ee.maven.version` is `${eap8.version}` (e.g. `8.0.0.GA-redhat-00007`), so dependencies like `org.jboss.eap:wildfly-ee-galleon-pack:${wildfly.version}` will point to a likely non-existent GAV and cause resolution/build failures when this profile is used; `wildfly.version` should remain aligned with the EAP version.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
👍 | 👎

<wildfly.build-tools.version>${eap8.wildfly.build-tools.version}</wildfly.build-tools.version>
<wildfly.core.version>${eap8.wildfly.core.version}</wildfly.core.version>
</properties>
Expand All @@ -1615,7 +1615,7 @@
<properties>
<ee.maven.groupId>org.wildfly</ee.maven.groupId>
<ee.maven.version>${upstream.wildfly.version}</ee.maven.version>
<wildfly.version>${upstream.wildfly.version}</wildfly.version>
<wildfly.version>39.0.0.Final</wildfly.version>
<wildfly.build-tools.version>${upstream.wildfly.build-tools.version}</wildfly.build-tools.version>
<wildfly.core.version>${upstream.wildfly.core.version}</wildfly.core.version>
</properties>
Expand Down
Loading