Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
</developer>
</developers>

<contributors></contributors>
<contributors/>

<modules>
<module>boms</module>
Expand Down Expand Up @@ -1602,7 +1602,7 @@
<ee.maven.version>${eap8.version}</ee.maven.version>
<wildfly.version>${eap8.version}</wildfly.version>
<wildfly.build-tools.version>${eap8.wildfly.build-tools.version}</wildfly.build-tools.version>
<wildfly.core.version>${eap8.wildfly.core.version}</wildfly.core.version>
<wildfly.core.version>30.0.0.Final</wildfly.core.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Replace the hardcoded version with a centralized property reference (use eap8.wildfly.core.version) to avoid duplicating the literal and prevent version drift. [maintainability]

</properties>
</profile>
<profile>
Expand All @@ -1617,7 +1617,7 @@
<ee.maven.version>${upstream.wildfly.version}</ee.maven.version>
<wildfly.version>${upstream.wildfly.version}</wildfly.version>
<wildfly.build-tools.version>${upstream.wildfly.build-tools.version}</wildfly.build-tools.version>
<wildfly.core.version>${upstream.wildfly.core.version}</wildfly.core.version>
<wildfly.core.version>30.0.0.Final</wildfly.core.version>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Replace the hardcoded version with a property reference (use upstream.wildfly.core.version) so the upstream-adapters profile uses the centralized version and avoids duplicate literals. [maintainability]

</properties>

</profile>
Expand Down
Loading