explain :DatasetPublishPopupCustomText vs :PublishDatasetDisclaimerText#12206
Merged
stevenwinship merged 1 commit intodevelopfrom Mar 11, 2026
Conversation
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
Mar 11, 2026
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the following PR we introduced a new setting called :PublishDatasetDisclaimerText
This new setting is strikingly similar to an older setting called :DatasetPublishPopupCustomText
Here's how they look in JSF when you enable both:
In this pull request, I'm crosslinking the two settings in the guides so that people who are customizing the publishing popup can more easily learn about the presence of both settings.
Preview the crosslinking here:
p.s. Here's the pull request on the SPA with a similar screenshot: