Open
Conversation
ekraffmiller
added
GREI Re-arch
ChengShi-1
reviewed
Mar 5, 2026
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Looks good! The notification works well (except for the create dataset you mentioned). The test coverage is failing now, but I guess it should pass after removing "only" in one test case.
| cy.get('@markAsRead').should('have.been.calledOnceWith', Cypress.sinon.match.number) | ||
| }) | ||
|
|
||
| it.only('does not render notifications display count when there are no notifications', () => { |
Contributor
There was a problem hiding this comment.
Could you remove the "only" here?
ChengShi-1
approved these changes
Mar 6, 2026
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Thanks for the change, approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refreshes the unread notifications list when these actions happen in the UI:
Which issue(s) this PR closes:
Special notes for your reviewer:
There is an issue with the create dataset API, it isn't generating a notification: IQSS/dataverse#12189
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes or changelog update needed for this change?:
Additional documentation: