Merged
Conversation
g-saracca
added
Size: 3
Contributor
Author
|
Updated branch with develop |
ChengShi-1
reviewed
Feb 25, 2025
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
good overall, just one concern
ChengShi-1
reviewed
Feb 26, 2025
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
There are something related to pid as well, and we could also add a functional test to it
Contributor
Author
|
Hi @ChengShi-1, I addressed all your requested changes. I didn't add functional test for this, there are already unit and integration tests, it's a little bit tricky to add functional tests for this as they depend on s3 bucket direct upload and it will require too much boilerplate for things that are tested already in the integration tests. |
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
tests are passing - Merging PR |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new use case to the package: Replace File.
It is focused when a Dataverse installation is configured to use S3 storage with direct upload enabled.
It is based on this API endpoint.
Which issue(s) this PR closes:
Suggestions on how to test this:
Code and Tests review.