Merged
Conversation
github-actions
bot
added
FY25 Sprint 17
Contributor
Author
|
@ChengShi-1, ready for review again, thanks! |
ChengShi-1
previously approved these changes
Feb 18, 2025
g-saracca
changed the title
Contributor
Author
|
@ChengShi-1 , I update the branch with develop and set .env file back to using unstable image 👍🏼 |
Contributor
|
tests passing - merging PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the Delete Collection use case.
I also add a query param by default to the Get Collection use case called childCount. This is needed to know if a collection has data in it, to only show the delete button when a collection has no data in it.
Which issue(s) this PR closes:
Related Dataverse PRs:
Once the above dataverse PR is merged we need to change test environment variables to use unstable and docker.io again.
Suggestions on how to test this:
Review code and tests.