Get Collection Items extension - Count per object type#240
Merged
ofahimIQSS merged 5 commits intodevelopfrom Feb 4, 2025
Merged
Get Collection Items extension - Count per object type#240ofahimIQSS merged 5 commits intodevelopfrom
ofahimIQSS merged 5 commits intodevelopfrom
Conversation
g-saracca
added
Size: 3
Contributor
Author
|
Ready for Review, I just update test environment from Github Registry Dataverse Image to unstable image from Docker and copy the fix from Ellen from her PR about metadata blocks length assertions changes. |
ChengShi-1
approved these changes
Feb 4, 2025
Contributor
There was a problem hiding this comment.
The dependent dataverse PR is merged, so we could dismiss the env. change.
Contributor
|
tests are passing, IQSS/dataverse#11138 has already been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Extends the use case to also return by default the count per object type info.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Tests are using image preview from PR 1127, this should be merged after that one is merged.
Suggestions on how to test this:
Visual code inspection and validate new tests