Merged
Conversation
… workflows to lastest nextcloud template https://github.com/nextcloud/.github
…it with MySQL and SQLite, static analysis, and REUSE compliance check
586f04c to
558f9a0
Compare
558f9a0 to
3640bdc
Compare
6dfd2e1 to
8a4599a
Compare
fe5b75c to
ee0e445
Compare
printminion-co
requested changes
Jan 15, 2026
Collaborator
printminion-co
left a comment
There was a problem hiding this comment.
review ok if proposed fixup commits on top are adrressed
There was a problem hiding this comment.
Pull request overview
This PR represents the initial version of the NCW Tools app, transitioning from an app template to a utility application. The app now provides event listeners and extensible tools for system administration and maintenance tasks in Nextcloud environments.
Changes:
- Renamed application from
app_templatetoncw_toolsacross all configuration and code files - Removed frontend components (Vue.js, Vite, npm dependencies) to focus on backend-only functionality
- Added comprehensive REUSE licensing configuration and license files for compliance
- Updated CI/CD workflows with newer action versions and configurations specific to backend-only testing
Reviewed changes
Copilot reviewed 44 out of 48 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/AppInfo/Application.php | Updated namespace and app ID constant to reflect new app name |
| appinfo/info.xml | Changed app metadata including ID, name, description, author, and removed navigation entries |
| composer.json | Updated package name and namespace mappings |
| tests/unit/AppInfo/ApplicationTest.php | Added comprehensive test suite for Application class |
| tests/bootstrap.php | Updated app reference in bootstrap loader |
| REUSE.toml | Added comprehensive licensing configuration for all file types |
| README.md | Replaced template instructions with actual app documentation |
| .github/workflows/* | Updated workflow files with newer action versions and backend-focused configuration |
| Various frontend files | Removed all Vue.js, TypeScript, and npm-related files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…allation and development instructions
Added detailed instructions for developers on using Copilot and guidelines for writing Git commit messages. This aims to standardize practices across the project and improve collaboration. The new files include: - `copilot-instructions.md`: Project-wide Copilot instructions for all developers. - `git-commit-instructions.md`: Quick reference for Git commit message guidelines. These documents provide essential context, repository structure, and best practices to enhance the development workflow.
Update .gitignore to exclude the coverage directory from version control, ensuring cleaner repository management.
Updated the test suite name in phpunit.xml to better reflect the project's purpose.
Added unit tests to verify the Application class functionality, including checks for the APP_ID constant, constructor initialization, and the existence of the register method. This enhances test coverage and ensures the Application class behaves as expected. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
bff21cc to
a616788
Compare
printminion-co
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.