NSW-774: user_saml: implement IDelegatedSettings for admin panel#275
Merged
printminion-co merged 3 commits intoionos-devfrom Mar 27, 2026
Merged
Conversation
This was referenced Mar 24, 2026
https://github.com/IONOS-Productivity/nc-user_saml/releases/tag/v7.1.3 git submodule add -f git@github.com:IONOS-Productivity/nc-user_saml.git apps-external/user_saml cd apps-external/user_saml git checkout v7.1.3 git submodule update --init apps-external/user_saml git add .gitmodules apps-external/user_saml
https://github.com/IONOS-Productivity/nc-user_saml/releases/tag/v7.1.3-6e99e21 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…n delegation for user_saml) https://github.com/IONOS-Productivity/ncw-config/releases/tag/5ed150c Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
printminion-co
force-pushed
the
mk/dev/nsw-774-user_saml-admin-delegation
branch
from
419b0a5 to
ba9c101
Compare
printminion-co
changed the base branch from
feature/add_app-user_saml-24032026_1426
to
ionos-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement
IDelegatedSettingsfor theuser_samlapp's admin settings panel so delegated admins can access SSO & SAML configuration without full admin rights.Changes in the
nc-user_samlfork (mk/dev/admin-delegation-user_saml):lib/Settings/Admin.php:ISettings→IDelegatedSettings, addgetName()+getAuthorizedAppConfig()tests/unit/Settings/AdminTest.php: typed props,declare(strict_types=1), new test methodsChecklist
.dev/container/check_release.sh pr-275 ncw— validate pr locallyVerification
After
check_release.sh pr-275 ncw:Expected:
OCA\User_SAML\Settings\Adminis listed and delegated toadmingroup.Hint: You can login without SAML via http://localhost:8080/index.php/login?direct=1