Skip to content

Comments

IONOS(ionos-mail): style(buttons): refine button hover styles for improved consistency#244

Merged
tanyaka merged 2 commits intorc/ncw-3from
as/dev/fix_shares_btns_hovers
Feb 17, 2026
Merged

IONOS(ionos-mail): style(buttons): refine button hover styles for improved consistency#244
tanyaka merged 2 commits intorc/ncw-3from
as/dev/fix_shares_btns_hovers

Conversation

@Arsalanulhaq
Copy link

Reverting the previous PR #209
removing !important from &.action-item__menutoggle:not(.unified-search-modal__header *), &.files-list__header-upload-button--disabled as it was causing conflict with &.button-vue--text-only. Now they already prioritized in css.

  • Resolves: #

Summary

TODO

  • ...

Checklist

@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/fix_shares_btns_hovers branch 2 times, most recently from 5bccffa to 351d941 Compare February 16, 2026 14:13
Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a new rc/ncw-3 branch to merge this into as we removed the original branch
Could also use ncw-3.1 or something

…button hover background color for cleaner CSS

Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
Copy link

@bromiesTM bromiesTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also something is not working with the '+ New' button of the files app. In default mode its not visible in light mode as text color is white and a background color is missing.
It should be a primary button but now has secondary colors

@tanyaka tanyaka force-pushed the as/dev/fix_shares_btns_hovers branch from 351d941 to a2384f9 Compare February 17, 2026 10:09
@tanyaka tanyaka changed the base branch from rc/ncw-4 to rc/ncw-3 February 17, 2026 10:09
…ed consistency

Signed-off-by: Arsalan Ul Haq Sohni <arsalan-ul-haq.sohni@strato.de>
@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/fix_shares_btns_hovers branch from a2384f9 to dd7988c Compare February 17, 2026 10:38
Copy link

@tanyaka tanyaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK.

@tanyaka tanyaka merged commit 7595559 into rc/ncw-3 Feb 17, 2026
10 of 12 checks passed
@tanyaka tanyaka deleted the as/dev/fix_shares_btns_hovers branch February 17, 2026 13:13
@Arsalanulhaq Arsalanulhaq added this to the ncw-3 milestone Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants