Fix inconsistent pattern matching syntax for rc/* branches#205
Merged
printminion-co merged 2 commits intomk/dev/change_trigger_branchfrom Jan 27, 2026
Merged
Fix inconsistent pattern matching syntax for rc/* branches#205printminion-co merged 2 commits intomk/dev/change_trigger_branchfrom
printminion-co merged 2 commits intomk/dev/change_trigger_branchfrom
Conversation
7 tasks
Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update workflow to add support for release candidate branches
Fix inconsistent pattern matching syntax for rc/* branches
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review identified inconsistent bash pattern matching for rc/* branch conditionals. Lines 779 and 951 used glob patterns (
== "rc/"*) while line 149 used regex (=~ ^rc/).Changes:
=~ ^rc/in bash conditionalsTODO
Checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.