Skip to content

Comments

Fix inconsistent pattern matching syntax for rc/* branches#205

Merged
printminion-co merged 2 commits intomk/dev/change_trigger_branchfrom
copilot/sub-pr-201
Jan 27, 2026
Merged

Fix inconsistent pattern matching syntax for rc/* branches#205
printminion-co merged 2 commits intomk/dev/change_trigger_branchfrom
copilot/sub-pr-201

Conversation

Copy link

Copilot AI commented Jan 27, 2026

Summary

Code review identified inconsistent bash pattern matching for rc/* branch conditionals. Lines 779 and 951 used glob patterns (== "rc/"*) while line 149 used regex (=~ ^rc/).

Changes:

  • Standardized all rc/* branch checks to use regex pattern =~ ^rc/ in bash conditionals
  • Updated ARTIFACTORY_STAGE_PREFIX assignment (line 779)
  • Updated BUILD_TYPE assignment (line 951)
# Before
elif [[ "${{ github.ref_name }}" == "rc/"* ]]; then

# After
elif [[ "${{ github.ref_name }}" =~ ^rc/ ]]; then

TODO

  • Fix pattern matching consistency

Checklist


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: printminion-co <145785698+printminion-co@users.noreply.github.com>
Copilot AI changed the title [WIP] Update workflow to add support for release candidate branches Fix inconsistent pattern matching syntax for rc/* branches Jan 27, 2026
Copilot AI requested a review from printminion-co January 27, 2026 10:41
@printminion-co printminion-co marked this pull request as ready for review January 27, 2026 10:44
@printminion-co printminion-co merged commit f5a36c5 into mk/dev/change_trigger_branch Jan 27, 2026
1 check failed
@printminion-co printminion-co deleted the copilot/sub-pr-201 branch January 27, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants