Skip to content

IONOS(admin-delegation): implement IDelegatedSettings for user_saml #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 2 commits into from
Mar 27, 2026
Merged

IONOS(admin-delegation): implement IDelegatedSettings for user_saml #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc04fb
IONOS(admin-delegation): implement IDelegatedSettings for user_saml
printminion-co Mar 25, 2026
6872fb9
IONOS(admin-delegation): update AdminTest for IDelegatedSettings
printminion-co Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/Settings/Admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
use OCP\Defaults;
use OCP\IConfig;
use OCP\IL10N;
use OCP\Settings\ISettings;
use OCP\Settings\IDelegatedSettings;
use OneLogin\Saml2\Constants;

class Admin implements ISettings {
class Admin implements IDelegatedSettings {

public function __construct(
private readonly IL10N $l10n,
Expand Down Expand Up @@ -254,4 +254,14 @@ public function getSection() {
public function getPriority() {
return 0;
}

#[\Override]
public function getName(): ?string {
return $this->l10n->t('SSO & SAML authentication');
}

#[\Override]
public function getAuthorizedAppConfig(): array {
return [];
}
}
35 changes: 25 additions & 10 deletions tests/unit/Settings/AdminTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

/**
* SPDX-FileCopyrightText: 2016 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
Expand All @@ -17,16 +19,11 @@
use PHPUnit\Framework\MockObject\MockObject;

class AdminTest extends \Test\TestCase {
/** @var SAMLSettings|MockObject */
private $settings;
/** @var Admin */
private $admin;
/** @var IL10N|\PHPUnit_Framework_MockObject_MockObject */
private $l10n;
/** @var Defaults|\PHPUnit_Framework_MockObject_MockObject */
private $defaults;
/** @var IConfig|\PHPUnit_Framework_MockObject_MockObject */
private $config;
private SAMLSettings&MockObject $settings;
private Admin $admin;
private IL10N&MockObject $l10n;
private Defaults&MockObject $defaults;
private IConfig&MockObject $config;

protected function setUp(): void {
$this->l10n = $this->createMock(IL10N::class);
Expand Down Expand Up @@ -289,4 +286,22 @@ public function testGetSection() {
public function testGetPriority() {
$this->assertSame(0, $this->admin->getPriority());
}

public function testGetName(): void {
$this->l10n->expects($this->once())
->method('t')
->with('SSO & SAML authentication')
->willReturn('SSO & SAML authentication');

$this->assertSame('SSO & SAML authentication', $this->admin->getName());
}

public function testGetAuthorizedAppConfig(): void {
$this->assertSame([], $this->admin->getAuthorizedAppConfig());
}

public function testImplementsIDelegatedSettings(): void {
$this->assertInstanceOf(\OCP\Settings\IDelegatedSettings::class, $this->admin);
$this->assertInstanceOf(\OCP\Settings\ISettings::class, $this->admin);
}
}