Conversation
in order to avoid hardcoded values use dynamic matrix Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…s/deep-copy, nikic/php-parser, and phpunit Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
fa6124b to
93d726d
Compare
18 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Nextcloud workflows to use the centralized organization templates and bumps the nextcloud/ocp dependency.
- Bump
nextcloud/ocpfrom v31.0.5 to v31.0.6 in composer.json - Switch all GitHub Actions workflows to the org-provided templates, update triggers to
pull_request, permissions, concurrency, and pinned action versions - Add
--no-scriptstocomposer removein PHP unit workflows and update service images
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Bump nextcloud/ocp to v31.0.6 |
| .github/workflows/reuse.yml | Switch to org-provided REUSE workflow; restrict trigger to PR; pin checkout & reuse-action versions |
| .github/workflows/phpunit-sqlite.yml | Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts |
| .github/workflows/phpunit-pgsql.yml | Migrate to org template; PR-only trigger; update Postgres image; pin setup-php; add --no-scripts |
| .github/workflows/phpunit-oci.yml | Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts |
| .github/workflows/phpunit-mysql.yml | Migrate to org template; PR-only trigger; pin setup-php; add --no-scripts |
| .github/workflows/lint-stylelint.yml | Migrate to org template; PR-only trigger; update SPDX header license |
| .github/workflows/lint-php.yml | Migrate to org template; PR-only trigger; add permissions, concurrency, matrix |
| .github/workflows/lint-php-cs.yml | Migrate to org template; PR-only trigger; add permissions, concurrency, dynamic PHP versions |
| .github/workflows/lint-info-xml.yml | Migrate to org template; PR-only trigger; update SPDX header license |
| .github/workflows/lint-eslint.yml | Migrate to org template; PR-only trigger; update setup-node version |
Comments suppressed due to low confidence (4)
.github/workflows/phpunit-sqlite.yml:124
- [nitpick] Adding
--no-scriptswill skip all Composer scripts, which may include cleanup or autoload generation needed by Nextcloud. Verify that skipping scripts doesn’t break the test setup, or consider running only the specific scripts you want to skip.
composer remove nextcloud/ocp --dev --no-scripts
.github/workflows/reuse.yml:12
- [nitpick] The
pushtrigger was removed, so REUSE checks will no longer run on direct pushes to main. Confirm that running only on pull requests matches your policy for compliance enforcement.
on: [pull_request]
.github/workflows/phpunit-pgsql.yml:81
- Using
:latestcan lead to non-reproducible CI runs if the image is updated. Consider pinning to a specific version or digest for consistent test environments.
image: ghcr.io/nextcloud/continuous-integration-postgres-16:latest # zizmor: ignore[unpinned-images]
.github/workflows/lint-php-cs.yml:36
- [nitpick] There's no space between
phpand the version variable in the step name, which may reduce readability. Consider renaming toSet up php ${{ steps.versions.outputs.php-min }}.
- name: Set up php${{ steps.versions.outputs.php-min }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.