dimclient/ndcli: do not build system package anymore#289
Merged
miesi-ionos merged 2 commits intoIONOS-Core:masterfrom Jan 17, 2025
zeromind:use-obs-and-pypi
Merged
dimclient/ndcli: do not build system package anymore#289miesi-ionos merged 2 commits intoIONOS-Core:masterfrom zeromind:use-obs-and-pypi
miesi-ionos merged 2 commits intoIONOS-Core:masterfrom
zeromind:use-obs-and-pypi
Conversation
do not build system packages anymore, we have OBS for that
do not build system packages anymore, we have OBS for that switch to oraclelinux:9 with the right Python for generating the man page, install dimclient from OBS
miesi-ionos
approved these changes
Jan 17, 2025
Collaborator
miesi-ionos
left a comment
miesi-ionos
left a comment
There was a problem hiding this comment.
Looks reasonable. I trust you that you tested it in your environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we're building system packages of
dimclientandndclifor quite a lot of Linux distributions on the public OBS, and publish them both on PyPI; remove building system package via GitHub Actions.They were broken due to external changes since some time, are more fragile and labour-intensive.
set-outputby switching to the alternativendclionoraclelinux:9asubuntu:latestdid not work anymoredimclientfrom public OBS instead of trying to find it in GitHub releasesThis fixes the
release_dimclientandrelease_ndcliworkflows.