-
Notifications
You must be signed in to change notification settings - Fork 1
Pypi branch #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pypi branch #16
Conversation
|
Hi! I hadn't reviewed the GUI branch because I wanted to discuss this with you... I have doubts on the necessity to merge the GUI branch at this stage (until we know how to deploy the GUI), and so I have doubts on the fact that this PR includes the GUI branch... Let's discuss! |
|
Hello, I have not yet tested the GUI branch, i prefer to test it before with the presence of @sifaoufatai in order to understand its functionality and its usefulness for the data manager ! |
|
I think we don't need to focus on deployment right now. Let's merge this and move forward. The next step will be to decide how we want to deploy it, but in any case, we can already use the version available via pip. |
|
My comments about the GUI: Will it not be much easier to add the functionality in GUI to chose each template parts file separately in the order the data manager wants ? |
|
So, as @SylvainTakerkart said, we skip the GUI for now .. |
|
This PR is now obsolete, it's been replaced by another one to configure Pypi... |
Description:
This branch was created from gui-branch and contains all the necessary settings and configurations to deploy the elabforms package to TestPyPI and PyPI. It is ahead of gui-branch and includes all of its changes.
Recommendation:
After your review, I recommend closing the gui-branch and merging only this branch (deployment) into the main branch, as it fully supersedes gui-branch.