Skip to content

Conversation

@sifaoufatai
Copy link
Contributor

Description:
This branch was created from gui-branch and contains all the necessary settings and configurations to deploy the elabforms package to TestPyPI and PyPI. It is ahead of gui-branch and includes all of its changes.
Recommendation:
After your review, I recommend closing the gui-branch and merging only this branch (deployment) into the main branch, as it fully supersedes gui-branch.

@SylvainTakerkart
Copy link
Contributor

Hi!

I hadn't reviewed the GUI branch because I wanted to discuss this with you... I have doubts on the necessity to merge the GUI branch at this stage (until we know how to deploy the GUI), and so I have doubts on the fact that this PR includes the GUI branch... Let's discuss!

@dumaatravaie
Copy link
Contributor

Hello, I have not yet tested the GUI branch, i prefer to test it before with the presence of @sifaoufatai in order to understand its functionality and its usefulness for the data manager !

@sifaoufatai
Copy link
Contributor Author

I think we don't need to focus on deployment right now. Let's merge this and move forward. The next step will be to decide how we want to deploy it, but in any case, we can already use the version available via pip.

@dumaatravaie
Copy link
Contributor

My comments about the GUI: Will it not be much easier to add the functionality in GUI to chose each template parts file separately in the order the data manager wants ?
In my opinion, for creating the template_list_files, the data manager must put all the template parts files in the order along with absolute file path! So, from the GUI the data manager may
not get much extra advantage. And, for the visualization of template, it takes you directly to the elab sites, so i have not tested whether the template will be uploaded automatically in
the desired project or not. There should also be an option to download the created template.

@dumaatravaie
Copy link
Contributor

So, as @SylvainTakerkart said, we skip the GUI for now ..

@SylvainTakerkart
Copy link
Contributor

This PR is now obsolete, it's been replaced by another one to configure Pypi...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants