Skip to content

Conversation

@benlk
Copy link
Contributor

@benlk benlk commented Jun 3, 2017

Changes

This includes all of #3:

  • Add commented-out new spreadsheet IDs
  • change production/staging ids in tarbell_config.py
  • comment out the boundary service call in get_data.py
  • comment out the geocoder in geocode_addresses() in lib/geocode_addresses.py
  • comment out some field mappings for Officers, and add latitude and longitude field mappings
  • comment out the timestamp field mapping for Victims
  • comment out a number of per-case keys that would otherwise be removed from the case
  • remove a bunch of stuff from the case search form.
  • better error handling
  • Include instruction to install Grunt
  • Updates URL from bitbucket to Github
  • updated versions of assets/

As well as:

  • Add some more comments describing spreadsheet rows (may not be valid after Friday, June 2)
  • a bunch of error-handling in case cases don't have attributes
  • adds ipdb and titlecase to pip requirements

Notes

  • we should maybe-probably uncomment officers_tags and victims_tags; I think they're part of the missing bits

Notable errors:

Missing details in the search page

screen shot 2017-06-01 at 4 27 26 pm

screen shot 2017-06-01 at 4 27 37 pm

A problem with search.js when served locally:

 search.js:292 Uncaught TypeError: Cannot read property 'match' of undefined
    at child.formatStr (search.js:292)
    at child.eval (eval at _.template (underscore.js:1454), <anonymous>:54:14)
    at child.template (underscore.js:1461)
    at search.js:198
    at Function._.each._.forEach (underscore.js:153)
    at child.each (backbone.js:87)
    at child.render (search.js:197)
    at triggerEvents (backbone.js:370)
    at triggerApi (backbone.js:356)
    at eventsApi (backbone.js:155)
    at child.Events.trigger (backbone.js:346)
    at child.reset (backbone.js:935)
    at child.loadData (search.js:96)
    at child.initialize (search.js:56)
    at child.Backbone.Router (backbone.js:1440)
    at new child (backbone.js:1852)
    at HTMLDocument.<anonymous> (search.js:780)
    at fire (jquery.js:3182)
    at Object.fireWith [as resolveWith] (jquery.js:3312)
    at Function.ready (jquery.js:3531)
    at HTMLDocument.completed (jquery.js:3547)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants