Enhance DIGIPIN API with full input validation, improved error handling, and middleware upgrades#3
Open
Rajdip585 wants to merge 3 commits intoINDIAPOST-gov:mainfrom
Open
Enhance DIGIPIN API with full input validation, improved error handling, and middleware upgrades#3Rajdip585 wants to merge 3 commits intoINDIAPOST-gov:mainfrom
Rajdip585 wants to merge 3 commits intoINDIAPOST-gov:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a set of improvements to the DIGIPIN API, focusing on input validation, error handling, and safer request processing.
The goal is to make the API more robust, predictable, and user-friendly while maintaining backward compatibility.
Key Improvements
1. Added Comprehensive Input Validation
isValidNumber()isValidString()2. Improved Error Handling
3. Middleware Enhancements
validateJsonContentTypemiddleware to enforceapplication/jsonfor POST requests.4. Route-Level Improvements
Files Updated
src/app.jssrc/routes/digipin.routes.jsserver.jsWhy These Changes Matter
Compatibility
✔ No breaking changes to the API structure
✔ Existing clients continue to work
✔ New validations only reject invalid data (expected behavior)
Request
Please review the changes and merge if they align with the project's direction.
I am open to adjustments or suggestions to align with your preferred coding style or architecture.
Thank you!