IMAP Lo: Metadata updates for background-subtracted ISN #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Updates to metadata for the background-subtracted ISN Lo L3 products. This is just the "easy" stuff, there's a lot more metadata related that impacts the code more directly (see "additional to do").
Overview
isn_rate_bg_subtracted-- wasisn_bg_rate_subtracted, implying it's a background with some other rate subtracted.isn_rate_bg_subtractednot surprisingly goes negative a lot. Because of how we've setVALIDMIN, that means these values will be replaced with fill in most analysis tools. If people are averaging over time, this will inflate the average rates. These negatives need to be included in any averaging. I've changed VALIDMIN and added a VAR_NOTE, but this needs another scientist eye on it. (Nathan?) EDIT: Nathan has given thumbs-up.bg_subtracted_stat_err, as that variable doesn't existAdditional to do
This should be either pushed to this PR before merge, or done just after merging, but this is the rest of metadata-related changes.
We should remove
geometric factorbecause these are rates, not intensities. (And thusgeometric_factor_stat_uncert). We should also removebg_rates,bg_rates_stat_uncert,bg_rates_sys_err,counts,ena_count_rate,ena_count_rate_stat_uncertas they are inputs from the L2. If we keep any of these, there are metadata updates to do. There may be an argument for calculating background subracted counts independent of the count rate, but that's a future enhancement -- we're not doing it in the ENA products.Nothing of interest to scientists below this, mostly bookkeeping
Variables
energy_label,longitude_label, andlatitude_labeldo not exist. Because these are coming in from isn_rate_data, maybe we address this in the input handling. We're not going to have separate L2 ISN right now, so if we use the main L2 ENA input that might fix it?Might this be the same for
energy_delta_plusandenergy_delta_minus? We also have a separateenergy_stat_uncertwhich doesn't seem relevant. I haven't updated metadata for this, not sure where it's coming from.longitude_deltaandlatitude_deltaalso do not exist, and the code does not appear to copy them in fromisn_rate_dataeven if present in that data set.Updated Files
isn_rate_bg_subtractedand clarifyingstat_uncandsys_errTesting
None done