Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to integrate the
SIMULON_VERSIONenvironment variable into the Docker build and application runtime. The most important changes include updating the Dockerfile to accept a build argument for the version, modifying the API to use this version, and ensuring the environment schema includes the version.Integration of
SIMULON_VERSION:.github/workflows/docker-publish.yml: Addedbuild-argsto pass the release tag name asSIMULON_VERSIONduring the Docker build process.Dockerfile: Introduced anARGforSIMULON_VERSIONand set it as an environment variable within the Docker container.apps/api/main.ts: Updated the API documentation version to use theSIMULON_VERSIONenvironment variable.packages/env/mod.ts: AddedSIMULON_VERSIONto the environment schema with a default value and transformation to strip a leading 'v'.